On Sun, Aug 09, 2009 at 11:42:32AM +0200, Julia Lawall wrote: > From: Julia Lawall <julia@xxxxxxx> > > request_region should be used with release_region, not request_mem_region. > > Geert Uytterhoeven pointed out that in the case of drivers/video/gbefb.c, > the problem is actually the other way around; request_mem_region should be > used instead of request_region. > > The semantic patch that finds/fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @r1@ > expression start; > @@ > > request_region(start,...) > > @b1@ > expression r1.start; > @@ > > request_mem_region(start,...) > > @depends on !b1@ > expression r1.start; > expression E; > @@ > > - release_mem_region > + release_region > (start,E) > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> Any reason this still hasn't been applied? Ralf
