On Fri, 11 Sep 2009 18:21:00 +0200 (CEST), Julia Lawall <julia@xxxxxxx> wrote: > From: Julia Lawall <julia@xxxxxxx> > > Error handling code following a kzalloc should free the allocated data. > Error handling code following an ioremap should iounmap the allocated data. > > The semantic match that finds the first problem is as follows: > (http://www.emn.fr/x-info/coccinelle/) Thank you for finding this out. This patch add some correctness, but obviously incomplete: there are more error pathes without iounmap/kfree/etc. in this function. And I like goto-style cleanup, as Mark Brown said in reply for your sound/soc patch. Could you make a new patch? --- Atsushi Nemoto
