Re: [PATCH] Alchemy: override loops_per_jiffy detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ralf,

On Thu, Aug 27, 2009 at 12:57 PM, Ralf Baechle<ralf@xxxxxxxxxxxxxx> wrote:
> On Sat, Aug 22, 2009 at 06:09:12PM +0200, Manuel Lauss wrote:
>
>> The loops_per_jiffy detection in generic calibrate_delay is a bit off
>> (by ~0.5% usually); calculate the correct value based on detected core
>> clock.  BogoMIPS value will now reflect cpu core clock correctly.
>
> It think this is pretty much solving a non-problem.

Pretty much, yeah, and it doesn't solve it completely either. With certain
frequencies the printed rate is wrong due to rouding ;-)


> Here's an even easier solution:
>
> #include <linux/jiffies.h>
> ...
>        preset_lpj = <loops_per_jiffie_value>;
>
> Avoid the change to Kconfig that eventually will become messy if other
> systems continue along this line.

Ah, much better.  I'll resend a tested new version in a few hours.

Thanks!
     Manuel Lauss


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux