On Sat, Aug 01, 2009 at 11:51:20PM +0200, Florian Fainelli wrote: > From: Florian Fainelli <florian@xxxxxxxxxxx> > Date: Sat, 1 Aug 2009 23:51:20 +0200 > To: Ralf Baechle <ralf@xxxxxxxxxxxxxx> > Cc: linux-mips@xxxxxxxxxxxxxx, Manuel Lauss <manuel.lauss@xxxxxxxxxxxxxx> > Subject: [PATCH] mtx-1: request button GPIO before setting its direction > Content-Type: text/plain; > charset="utf-8" > > This patch fixes the following warning at boot time: > WARNING: at drivers/gpio/gpiolib.c:83 0x8021d5e0() > autorequest GPIO-207 > Modules linked in: > Call Trace:[<8011e0ec>] 0x8011e0ec > [<80110a28>] 0x80110a28 > [<80110a28>] 0x80110a28 > [..snip..] > > The current code does not request the GPIO and attempts > to set its direction, which is a violation of the GPIO API. > This patch also unhardcode the GPIO we request and use > the one we defined in the button driver. Thanks, applied. Ralf
