On Sat, Jul 11, 2009 at 4:51 AM, Shane McDonald <mcdonald.shane@xxxxxxxxx> wrote:
OK, I've done my cooking, and the cleanup patch will follow in a separate email. It expects Florian's patch to have been applied.
Florian's patch is correct, so I'll add my:
Acked-by: Shane McDonald <mcdonald.shane@xxxxxxxxx>
Shane
Hi Florian:
My apologies for the delay in replying to your latest prompt -- I've been on vacation with little internet access.
Your patch looks correct to me, but as Ralf says, the existing code is a little suspect. In my poking around, I've come across three different versions of this file: the in-tree version, the latest out-of-tree patch from PMC-Sierra, and an unreleased version from a colleague. None appear to be quite correct. I think I've got enough info, though, to come up with a good version.
I'll cook something up this weekend and get it posted.
OK, I've done my cooking, and the cleanup patch will follow in a separate email. It expects Florian's patch to have been applied.
Florian's patch is correct, so I'll add my:
Acked-by: Shane McDonald <mcdonald.shane@xxxxxxxxx>
Shane