On Sun, Jun 14, 2009 at 8:54 AM, Wu Zhangjin<wuzhangjin@xxxxxxxxx> wrote: > From: Wu Zhangjin <wuzj@xxxxxxxxxx> > > when compiling linux-mips with kmemtrace enabled, this error will be > there: > > include/linux/trace_seq.h:12: error: 'PAGE_SIZE' undeclared here (not in > a function) > > I checked the source code and found trace_seq.h used PAGE_SIZE but not > include the relative header file, so, fix it via adding the header file > <asm/page.h> > > this error will not be triggered in linux-x86 for there is a > <asm/page.h> header file included in a certain header file. but which > not means <asm/page.h> is not needed in trace_seq.h > > Signed-off-by: Wu Zhangjin <wuzj@xxxxxxxxxx> This looks like a generic tracing issue, not a kmemtrace problem so the subject line needs fixing. But the change looks good to me: Acked-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
