First of all, sorry for late comment and thanks to Zhangjin for the great work. However, I have some suggestions. On 20:58 Thu 04 Jun , wuzhangjin@xxxxxxxxx wrote: > Wu Zhangjin (25): > add vmlinux.32 in .gitignore > fix-warning: incompatible argument type of pci_fixup_irqs > fix-warning: incompatible argument type of virt_to_phys I think these 3 patch could be submitted separately, since they are not quite related to Loongson. > change the naming methods In this patch, I found function get_system_type() still returns wrong name, "lemote-fulong". In later patches, I found this string was changed to a macro, MACH_NAME. Then, the function becomes more complicated and/or sophisticated, because of the addition of machname array. I don't know if this is an established or widely accepted policy, but intuitively, at the very least IMHO, a series of patches should only provide one correct implementation of a particular function, not provide one wrong function then override it with a correct one. If I were you, I would do a 'git reset' first. Then 'git add' and/or 'git rm' some files which contain similar changes. Then 'git commit'. Repeat the last two steps, until all the changes have been committed. -- Zhang, Le Gentoo/Loongson Developer http://zhangle.is-a-geek.org 0260 C902 B8F8 6506 6586 2B90 BC51 C808 1E4E 2973
Attachment:
pgpTvm6gc6vLR.pgp
Description: PGP signature
