Re: [alsa-devel] [PATCH 4/7] Alchemy: DB1200 AC97+I2S audio support.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mark,

> You should convert the DAI drivers to probe as normal platform devices
> and attach the resources used by the CPU to those devices rather than
> attaching the data to soc-audio.  pxa2xx-ac97 does this, as do the
> PowerPC drivers and the s3c64xx-i2s driver.  The DaVinci drivers
> currently on the davinci branch of my git for merge after the merge
> window do this too.

I see now what you mean, but this is ugly as sin:
I now need to register 2 platform devices in the board code: 1 for the DAI
(with resources mmio + irq) and 1 for the DMA engine (with ddma id resources),
or register the DMA engine device from within the AC97/I2S drivers.

This is in my opinion even worse than the current scheme, which at least allows
me to group all PSC resources into one struct resource which all audio-related
drivers can share without too much uglyness.

       Manuel Lauss


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux