6358 has 40 gpio whereas 6348 has 37, so set the maximum number of gpio at runtime. Also remove NR_BUILTIN_GPIO which does not seem to be used anymore. Signed-off-by: Maxime Bizon <mbizon@xxxxxxxxxx> --- arch/mips/bcm63xx/gpio.c | 4 ++-- arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h | 12 ++++++++++-- arch/mips/include/asm/mach-bcm63xx/gpio.h | 2 -- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/arch/mips/bcm63xx/gpio.c b/arch/mips/bcm63xx/gpio.c index 997fcaa..97e3730 100644 --- a/arch/mips/bcm63xx/gpio.c +++ b/arch/mips/bcm63xx/gpio.c @@ -117,11 +117,11 @@ static struct gpio_chip bcm63xx_gpio_chip = { .get = bcm63xx_gpio_get, .set = bcm63xx_gpio_set, .base = 0, - .ngpio = BCM63XX_GPIO_COUNT, }; int __init bcm63xx_gpio_init(void) { - printk(KERN_INFO "registering %d GPIOs\n", BCM63XX_GPIO_COUNT); + bcm63xx_gpio_chip.ngpio = bcm63xx_gpio_count(); + printk(KERN_INFO "registering %d GPIOs\n", bcm63xx_gpio_chip.ngpio); return gpiochip_add(&bcm63xx_gpio_chip); } diff --git a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h index 7f5d8e8..76a0b72 100644 --- a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h +++ b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_gpio.h @@ -5,8 +5,16 @@ int __init bcm63xx_gpio_init(void); -/* all helpers will BUG() if gpio count is >= 37. */ -#define BCM63XX_GPIO_COUNT 37 +static inline unsigned long bcm63xx_gpio_count(void) +{ + switch (bcm63xx_get_cpu_id()) { + case BCM6358_CPU_ID: + return 40; + case BCM6348_CPU_ID: + default: + return 37; + } +} #define GPIO_DIR_OUT 0x0 #define GPIO_DIR_IN 0x1 diff --git a/arch/mips/include/asm/mach-bcm63xx/gpio.h b/arch/mips/include/asm/mach-bcm63xx/gpio.h index 033c997..7cda8c0 100644 --- a/arch/mips/include/asm/mach-bcm63xx/gpio.h +++ b/arch/mips/include/asm/mach-bcm63xx/gpio.h @@ -3,8 +3,6 @@ #include <bcm63xx_gpio.h> -#define NR_BUILTIN_GPIO BCM63XX_GPIO_COUNT - #define gpio_to_irq(gpio) NULL #define gpio_get_value __gpio_get_value -- 1.6.0.4