On Thu, 28 May 2009, Steven Rostedt wrote: > On Thu, 28 May 2009, wuzhangjin@xxxxxxxxx wrote: > Could you possibly break this patch up into porting the tracers one by > one. That is: > > First patch: make function tracing work. > Second patch: make dynamic tracing work. > Third patch: add Function graph tracing. > Forth patch: the time stamp updates > > This would make things a lot easier to review, and if one of the changes > breaks something, it will be easier to bisect. > > include/linux/clocksource.h | 4 +- > > kernel/sched_clock.c | 2 +- > > kernel/trace/ring_buffer.c | 3 +- > > kernel/trace/trace_clock.c | 2 +- > > scripts/Makefile.build | 1 + > > scripts/recordmcount.pl | 31 +++- The changes to these generic files need to be separate as well. Thanks, tglx