On Fri, May 22, 2009 at 07:03:28AM +0200, Florian Fainelli wrote: > That's actually 14, numbering starting from 0, I should learn how to count. > Ralf, do you want me to resubmit that one with the proper message / > descriptions ? > > > > > > rb532_gpio_set_istat(0, irq_nr - GPIO_MAPPED_IRQ_BASE); > > > > > > /* > > > @@ -174,7 +175,7 @@ static int rb532_set_type(unsigned int irq_nr, > > > unsigned type) int gpio = irq_nr - GPIO_MAPPED_IRQ_BASE; > > > int group = irq_to_group(irq_nr); > > > > > > - if (group != GPIO_MAPPED_IRQ_GROUP) > > > + if (group != GPIO_MAPPED_IRQ_GROUP || irq_nr > (GROUP4_IRQ_BASE + 13)) > > > > ... and >= here. > > > > > return (type == IRQ_TYPE_LEVEL_HIGH) ? 0 : -EINVAL; > > > > > > switch (type) { Queued for 2.6.31 with the comment fix and the change from > to >=. Thanks, Ralf