On Mon, May 4, 2009 at 6:57 PM, David VomLehn <dvomlehn@xxxxxxxxx> wrote: > Most platforms can get by perfectly well with the default command line size, > but some platforms need more. This patch allows the command line size to > be configured for those platforms that need it. The default remains 256 > characters. The one thing I see when I look at this patch, is that it lands in the arch/mips/Kconfig -- but is there really anything fundamentally architecture specific about the allowed length of the kernel command line?. It probably belongs somewhere alongside the setting for LOG_BUF_LEN or similar (and then add the other respective changes to make all arch actually respect the setting.) Paul. > > Signed-off-by: David VomLehn <dvomlehn@xxxxxxxxx> > --- > arch/mips/Kconfig | 7 +++++++ > arch/mips/include/asm/setup.h | 2 +- > 2 files changed, 8 insertions(+), 1 deletions(-) > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index 998e5db..99f7b6d 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -780,6 +780,13 @@ config EARLY_PRINTK > config SYS_HAS_EARLY_PRINTK > bool > > +config COMMAND_LINE_SIZE > + int "Maximum size of command line passed to kernel from bootloader" > + default 256 > + help > + Most systems work well with the default value, but some bootloaders pass more > + information on the command line than others. A smaller value is good here. > + > config HOTPLUG_CPU > bool > default n > diff --git a/arch/mips/include/asm/setup.h b/arch/mips/include/asm/setup.h > index e600ced..132e397 100644 > --- a/arch/mips/include/asm/setup.h > +++ b/arch/mips/include/asm/setup.h > @@ -1,7 +1,7 @@ > #ifndef _MIPS_SETUP_H > #define _MIPS_SETUP_H > > -#define COMMAND_LINE_SIZE 256 > +#define COMMAND_LINE_SIZE CONFIG_COMMAND_LINE_SIZE > > #ifdef __KERNEL__ > extern void setup_early_printk(void); > >
