On Wed, Apr 22, 2009 at 8:40 AM, Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote: > This patch adds support for the integrated DMAC of the TXx9 family. > > Signed-off-by: Atsushi Nemoto <anemo@xxxxxxxxxxxxx> Acked-by: Dan Williams <dan.j.williams@xxxxxxxxx> > +static void > +txx9dmac_descriptor_complete(struct txx9dmac_chan *dc, > + struct txx9dmac_desc *desc) [..] > + /* > + * We use dma_unmap_page() regardless of how the buffers were > + * mapped before they were submitted... > + */ This will be caught by the new dma-mapping debug infrastructure that went in for 2.6.30, but I would not hold up merging this driver for this issue. Once Maciej's fix [1] goes upstream you can fix up your driver to use the new "unmap single" flags. Thanks, Dan [1]: http://marc.info/?l=linux-kernel&m=124049040806961&w=2