* Wu Zhangjin <wuzhangjin@xxxxxxxxx> wrote: > On Sun, 2009-04-19 at 17:24 +1000, Stephen Rothwell wrote: > > Hi Ralf, > > > > You probably already now about this, but our build (mips ip32_defconfig) > > of Linus' tree (commit aefe6475720bd5eb8aacbc881488f3aa65618562 "Merge > > branch 'upstream-linus' of > > git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev") gets > > these errors (we have actually been getting these errors since 2.6.30-rc1): > > > > In file included from arch/mips/include/asm/compat.h:7, > > from include/linux/compat.h:15, > > from arch/mips/kernel/asm-offsets.c:12: > > include/linux/seccomp.h: In function 'prctl_get_seccomp': > > include/linux/seccomp.h:30: error: 'EINVAL' undeclared (first use in this function) > > include/linux/seccomp.h:30: error: (Each undeclared identifier is reported only once > > include/linux/seccomp.h:30: error: for each function it appears in.) > > include/linux/seccomp.h: In function 'prctl_set_seccomp': > > include/linux/seccomp.h:35: error: 'EINVAL' undeclared (first use in this function) > > > > perhaps you can fix it like this: > > include/linux/seccomp.h > > 22 #else /* CONFIG_SECCOMP */ > 23 > 24 +#include <asm-generic/errno-base.h> > 25 > 26 typedef struct { } seccomp_t; > > in reality, there is a previous email sent by Ralf for it: > > http://lkml.indiana.edu/hypermail/linux/kernel/0904.2/01152.html Yes, that looks like the right kind of fix. Ralf, will you push that fix upstream, or should i do it? Thanks, Ingo