Re: [PATCH 0/3] Alchemy: platform updates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

Manuel Lauss wrote:

Patch overview:

#1: eliminate alchemy/common/platform.c.  Add platform device
    registration to all boards instead.

I'm strongly voting against this, as it causes totally unneeded code duplication. Please don't apply.

    I realize this is a lot of (needless) code duplication at first,
    but it seems a lot cleaner to me if each board registered the
    devices it needs/wants.

No, it's certainly a step backwards. You could make the common code more flexible by checking what devices are enabled and registering them selectively as I have already suggested several months ago. That would be the clean solution unlike your code bloat.

WBR, Sergei




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux