On Tue, Mar 17, 2009 at 5:49 PM, Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote: > On Tue, 17 Mar 2009 10:02:14 -0700, Dan Williams <dan.j.williams@xxxxxxxxx> wrote: > BTW, there are another holes in dma_async_device_register. If > idr_pre_get or idr_get_new was failed, idr_ref will not be freed. Thanks for these fixlets, I appreciate it. Now, back to the issue at hand. Does your driver still need direct control over chan->chan_id, or can it now rely on the fact that dma_async_device_register() will fail if a channel is not initialized? Or, just use some platform_data to identify the channel in the same manner as atmel-mci? Regards, Dan