Thanks Mark. On 26.02.09 11:30:48, M. Asselstine wrote: > > > + if (cpu_has_mips_r2 && !(read_c0_cause() & (1 << 26))) > > > > Do not use magic numbers. > > > > A comment will be added or a well named define. I found this: arch/mips/include/asm/mipsregs.h:#define CAUSEB_CE 28 Not sure if this is the same register. If so, you could add the macro to mipsregs.h too. -Robert -- Advanced Micro Devices, Inc. Operating System Research Center email: robert.richter@xxxxxxx