On Fri, Nov 28, 2008 at 08:45:10PM +0100, Phil Sutter wrote: > + switch (type) { > + case IRQ_TYPE_LEVEL_HIGH: > + rb532_gpio_set_ilevel(1, gpio); > + break; > + case IRQ_TYPE_LEVEL_LOW: > + rb532_gpio_set_ilevel(0, gpio); > + break; > + default: > + return -EINVAL; > + } Linux coding style - the case and default labels should have the same indentation level as the switch statement. I fixed that. Applied, thanks. Ralf