> + reg_cfg.s.orbit = 0; /* Don't combine with previos region */ previous ... > +static unsigned int octeon_cf_qc_issue(struct ata_queued_cmd *qc) > + case ATAPI_PROT_DMA: > + dev_err(ap->dev, "Error, ATAPI not supported\n"); > + BUG(); Looks as if you should also have a check_atapi_dma function that always returns non zero (or a mode filter for atapi -> pio) Looks good to me.