Re: [PATCH] ide: New libata driver for OCTEON SOC Compact Flash interface.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > +                iowrite16(*(uint16_t *)buffer, data_addr);
> 
>     Not seeing the reason to use iowrite16() and not writew() as registers are 
> always memory mapped...

iomap uses iowrite/ioread, writew is for the older ioremap stuff. Mixing
them up is not guaranteed to work for all ports.

> > + * Get the status of the DMA engine. The results of this function
> > + * must emulate the BMDMA engine expected by libata.
> 
>     Ugh... At least the IDE core is not so retarded.

Nor is libata, but he is piggybacking on the SFF code hence this.

Alan


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux