On Tue, 18 Nov 2008 14:24:14 -0800 David Daney <ddaney@xxxxxxxxxxxxxxxxxx> wrote: > In order to use Cavium OCTEON specific serial i/o drivers, we first > patch the 8250 driver to use replaceable I/O functions. Compatible > I/O functions are added for existing iotypeS. > > An added benefit of this change is that it makes it easy to factor > some of the existing special cases out to board/SOC specific support > code. > > The alternative is to load up 8250.c with a bunch of OCTEON specific > iotype code and bug work-arounds. Neither are pretty but this looks the better option I agree. Only niggle is the use of "_fn" - Linux generally doesn't put types into variable names.