On Thu, 20 Nov 2008 16:45:33 +0100, Alessandro Zummo <alessandro.zummo@xxxxxxxxxxxx> wrote: > > +struct tx4939rtc_plat_data { > > + struct rtc_device *rtc; > > + struct tx4939_rtc_reg __iomem *rtcreg; > > + spinlock_t lock; > > +}; > > is the additional lock necessary? It is used to protect sysfs nvram access from rtc ops. Hm, can I use rtc->ops_lock in sysfs read/write routine to achieve it? I will address all other issues. Thanks. --- Atsushi Nemoto