Hi Phil, Le Thursday 30 October 2008 18:47:15 Phil Sutter, vous avez écrit : > Sounds reasonable to me. So I'll prepare a patch which: > * removes the function pointers from rb532_gpio_chip > * exports getters and setters for interrupt status and level > > The GPIO config and function registers should indeed only be accessed at > bootup, so the corresponding getters/setters will be only locally > accessible in arch/mips/rb532/gpio.c. Doing it this way also prevents > any driver from breaking others, as the complete GPIO configuration will > be done at a single place (i.e., inside gpio.c). IIRC pata-rb532-cf did > use them only at initialisation state and to prevent the described > situation. Perfect. > > I got the pata driver working by the way. I just wanted to get a > solution for the GPIO problem first, as it needs to access interrupt > level and status at least. Great :) Good job. -- Best regards, Florian Fainelli Email : florian@xxxxxxxxxxx http://openwrt.org -------------------------------
Attachment:
signature.asc
Description: This is a digitally signed message part.
