On Tue, Oct 28, 2008 at 04:02:44PM +0000, Maciej W. Rozycki wrote: > > > +/* 144 - 151 represent the i8259 master */ > > > +#define OCTEON_IRQ_I8259M0 144 > > > +#define OCTEON_IRQ_I8259M1 145 > > > +#define OCTEON_IRQ_I8259M2 146 > > > +#define OCTEON_IRQ_I8259M3 147 > > > +#define OCTEON_IRQ_I8259M4 148 > > > +#define OCTEON_IRQ_I8259M5 149 > > > +#define OCTEON_IRQ_I8259M6 150 > > > +#define OCTEON_IRQ_I8259M7 151 > > > +/* 152 - 159 represent the i8259 slave */ > > > +#define OCTEON_IRQ_I8259S0 152 > > > +#define OCTEON_IRQ_I8259S1 153 > > > +#define OCTEON_IRQ_I8259S2 154 > > > +#define OCTEON_IRQ_I8259S3 155 > > > +#define OCTEON_IRQ_I8259S4 156 > > > +#define OCTEON_IRQ_I8259S5 157 > > > +#define OCTEON_IRQ_I8259S6 158 > > > +#define OCTEON_IRQ_I8259S7 159 > > > > You have some code for an i8259. Since ISA interrupts are well known > > numbers which are even hardcoded in drivers, manuals, printed on PCBs > > etc. I recommend to renumber interrupts such that i8259 interrupts are > > interrupts 0..15 and everything else follows after. Oh the pleassures > > of ISA cruft. > > I have long had plans to lift this stupid assumption and if I finally > lose my patience, I may even actually do it one day. ;) If we're talking about actual ISA cards - I don't think we should even try to remove the restriction. Interrupt numbers are printed on PCBs and the sysadmin has to jumper the bloody board so for sanity and consistency we rather stick to 0..15 for these systems. It's different for systems that only have on-board ISA-peripherals with no jumpers - but making that difference only makes it more complicated again ... Ralf
