Re: [PATCH] Fixes small option parsing bug in au1100fb.c.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Jan 08, 2008 at 12:39:45PM +0100, Freddy Spierenburg wrote:
> I've noticed that drivers/video/au1100fb.c contains a small time
> option parsing bug. In the middle of an if...else if...
> construction was inserted a lonesome if on it's own. This is
> causing an incorrect 'unsupported option' warning, while the
> option itself is parsed successfully.
> 
> This patch makes the lonesome if part of the whole if...else
> if... construction, like it should be. No longer the incorrect
> warning message will be displayed.
> 
> 
> Signed-off-by: Freddy Spierenburg <freddy@xxxxxxxxxxxxxxx>

The email above I wrote last january. Unfortunately 2.6.26.2
still does not feature this correction. I tested it today and
the patch still applies cleanly. I myself use this patch and can
confirm it works.

Can anybody please apply?


-- 
$ cat ~/.signature
Freddy Spierenburg <freddy@xxxxxxxxxxxxxxx>  http://freddy.snarl.nl/
GnuPG: 0x7941D1E1=C948 5851 26D2 FA5C 39F1  E588 6F17 FD5D 7941 D1E1
$ # Please read http://www.ietf.org/rfc/rfc2015.txt before complain!
diff -Naur linux-2.6.23-orig/drivers/video/au1100fb.c linux-2.6.23/drivers/video/au1100fb.c
--- linux-2.6.23-orig/drivers/video/au1100fb.c	2008-01-08 11:07:13.000000000 +0000
+++ linux-2.6.23/drivers/video/au1100fb.c	2008-01-08 11:13:37.000000000 +0000
@@ -707,7 +707,8 @@
  					print_warn("Panel %s not supported!", this_opt);
 				}
 			}
-			if (!strncmp(this_opt, "nocursor", 8)) {
+			/* No cursor option */
+			else if (!strncmp(this_opt, "nocursor", 8)) {
 				this_opt += 8;
 				nocursor = 1;
 				print_info("Cursor disabled");

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux