On Mon, Aug 04, 2008 at 10:51:51AM +0900, Atsushi Nemoto wrote: > On Sun, 3 Aug 2008 19:41:40 +0200 (CEST), Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> wrote: > > This driver replaces the broken ip27-rtc driver in drivers/char and > > gives back RTC support for SGI IP27 machines. > ... > > +config RTC_DRV_M48T35 > > + tristate "ST M48T35" > > + depends on SGI_IP27 > > Is this driver really IP27 specific? Let's make drivers generic as > possible. ok, will change that. > > + if ((hrs >= 24) || (min >= 60) || (sec >= 60)) > > + return -EINVAL; > > rtc_valid_tm() can be used? good idea. > > + priv->baseaddr = res->start; > > + priv->reg = (struct m48t35_rtc __iomem *)res->start; > > It seems priv->baseaddr is a physical address and priv->reg is a > virtual address. ioremap() is not needed? I've misued res->start to pass the pointer, which was used by the old rtc driver. I'll switch over to pass a physical address and add ioremap code. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessary a good idea. [ RFC1925, 2.3 ]
