Ralf, On Mon, 2008-07-28 at 23:36 +0100, Ralf Baechle wrote: > On Mon, Jul 28, 2008 at 01:09:26PM -0500, Kevin Hickey wrote: > > > An earlier update changed some calls from simple_strotl to > > strict_strtol but did not account for the differences in the syntax > > between the calls.simple_strotl returns the integer; strict_strtol > > returns an error code and takes a pointer to the result. As it was, > > NULL was being passed in place of the result, which led to failures > > during kernel initialization when using YAMON. > > > > Signed-off-by: Kevin Hickey <khickey@xxxxxxxxxxx> > > > > arch/mips/au1000/db1x00/init.c | 2 +- > > arch/mips/au1000/mtx-1/init.c | 2 +- > > arch/mips/au1000/pb1000/init.c | 2 +- > > arch/mips/au1000/pb1100/init.c | 2 +- > > arch/mips/au1000/pb1200/init.c | 2 +- > > arch/mips/au1000/pb1500/init.c | 2 +- > > arch/mips/au1000/pb1550/init.c | 2 +- > > arch/mips/au1000/xxs1500/init.c | 2 +- > > 8 files changed, 8 insertions(+), 8 deletions(-) > > One little nit on the submission format - if you include a diffstat, please > put it after a line consisting only of three - like this: It was only after creating this that I discovered git-format-patch. I'll use that in the future (I can assume that it handles stat lines correctly, right?). > > --- > arch/mips/au1000/db1x00/init.c | 2 +- > arch/mips/au1000/mtx-1/init.c | 2 +- > arch/mips/au1000/pb1000/init.c | 2 +- > > This keeps git and other tools that try to extract the body of the mail > for the description from considering the diffstat as part of the > description. > > Patch applied, thanks! Thanks! Is there any chance of this making it into 2.6.27? I saw that Linus marked the master branch as 2.6.27-rc1 today, so I'm not very optimistic. But I have to make some decisions about internal releases etc and I'm still trying to get a handle on how the kernel gets versioned. > > Ralf > -Kevin
