On Fri, Jul 25, 2008 at 07:49:58PM +0200, Jiri Slaby wrote: > ds1286_get_time(); is not called from atomic context, sleep for 20 ms is > better choice than a (home-made) busy waiting for such a situation. > > Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx> > Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx> Looks ok to me I guess. Though I don't really think it matters ... Acked-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx> The same condition also appears in drivers/char/rtc.c and maybe a few others. Rtc.c has been copies and modified several times. Ralf
