Kevin Hickey wrote: > I found this when I updated to version 2.6.26. None of my development > boards would boot. It appears that a previous update changed some calls > to simple_strtol to strict_strtol but did not account for the different > call semantics. Hi Kevin, 1) you forgot to sign your patch off; 2) please consider using git to generate and submit patches. At least according to my experience, it's much more convenient than any other approach. 3) As I can see, the board-specific code is almost identical for the pb1x00 boards. While at it, would you please try to merge it? Regards, Dmitri > > Index: arch/mips/au1000/pb1000/init.c > =================================================================== > --- arch/mips/au1000/pb1000/init.c > +++ arch/mips/au1000/pb1000/init.c > @@ -52,6 +52,6 @@ > if (!memsize_str) > memsize = 0x04000000; > else > - memsize = strict_strtol(memsize_str, 0, NULL); > + strict_strtol(memsize_str, 0, &memsize); > add_memory_region(0, memsize, BOOT_MEM_RAM); > } > Index: arch/mips/au1000/pb1100/init.c > =================================================================== > --- arch/mips/au1000/pb1100/init.c > +++ arch/mips/au1000/pb1100/init.c > @@ -54,7 +54,7 @@ > if (!memsize_str) > memsize = 0x04000000; > else > - memsize = strict_strtol(memsize_str, 0, NULL); > + strict_strtol(memsize_str, 0, &memsize); > > add_memory_region(0, memsize, BOOT_MEM_RAM); > } > Index: arch/mips/au1000/pb1200/init.c > =================================================================== > --- arch/mips/au1000/pb1200/init.c > +++ arch/mips/au1000/pb1200/init.c > @@ -53,6 +53,6 @@ > if (!memsize_str) > memsize = 0x08000000; > else > - memsize = strict_strtol(memsize_str, 0, NULL); > + strict_strtol(memsize_str, 0, &memsize); > add_memory_region(0, memsize, BOOT_MEM_RAM); > } > Index: arch/mips/au1000/mtx-1/init.c > =================================================================== > --- arch/mips/au1000/mtx-1/init.c > +++ arch/mips/au1000/mtx-1/init.c > @@ -55,6 +55,6 @@ > if (!memsize_str) > memsize = 0x04000000; > else > - memsize = strict_strtol(memsize_str, 0, NULL); > + strict_strtol(memsize_str, 0, &memsize); > add_memory_region(0, memsize, BOOT_MEM_RAM); > } > Index: arch/mips/au1000/pb1500/init.c > =================================================================== > --- arch/mips/au1000/pb1500/init.c > +++ arch/mips/au1000/pb1500/init.c > @@ -53,6 +53,6 @@ > if (!memsize_str) > memsize = 0x04000000; > else > - memsize = strict_strtol(memsize_str, 0, NULL); > + strict_strtol(memsize_str, 0, &memsize); > add_memory_region(0, memsize, BOOT_MEM_RAM); > } > Index: arch/mips/au1000/xxs1500/init.c > =================================================================== > --- arch/mips/au1000/xxs1500/init.c > +++ arch/mips/au1000/xxs1500/init.c > @@ -53,6 +53,6 @@ > if (!memsize_str) > memsize = 0x04000000; > else > - memsize = strict_strtol(memsize_str, 0, NULL); > + strict_strtol(memsize_str, 0, &memsize); > add_memory_region(0, memsize, BOOT_MEM_RAM); > } > Index: arch/mips/au1000/pb1550/init.c > =================================================================== > --- arch/mips/au1000/pb1550/init.c > +++ arch/mips/au1000/pb1550/init.c > @@ -53,6 +53,6 @@ > if (!memsize_str) > memsize = 0x08000000; > else > - memsize = strict_strtol(memsize_str, 0, NULL); > + strict_strtol(memsize_str, 0, &memsize); > add_memory_region(0, memsize, BOOT_MEM_RAM); > } > Index: arch/mips/au1000/db1x00/init.c > =================================================================== > --- arch/mips/au1000/db1x00/init.c > +++ arch/mips/au1000/db1x00/init.c > @@ -57,6 +57,6 @@ > if (!memsize_str) > memsize = 0x04000000; > else > - memsize = strict_strtol(memsize_str, 0, NULL); > + strict_strtol(memsize_str, 0, &memsize); > add_memory_region(0, memsize, BOOT_MEM_RAM); > } >
