On Fri, 25 Jul 2008, I wrote:
>> --- a/arch/mips/kernel/setup.c
>> +++ b/arch/mips/kernel/setup.c
>> @@ -78,7 +78,7 @@ void __init add_memory_region(phys_t start, phys_t size, long type)
>>
>> /* Sanity check */
>> if (start + size < start) {
>> - printk("Trying to add an invalid memory region, skipped\n");
>> + printk(KERN_WARNING "Trying to add an invalid memory region, skipped\n");
On Fri, Jul 25, 2008 at 08:04:57PM +0200, Geert Uytterhoeven wrote:
> Why not convert to pr_warning(), while you're at it?
I can do. I'm just a bit behind the times. :-)
Should I use pr_{warning,err,info} everywhere rather than printk? Is
it worth fixing up the other calls to printk that I didn't need to
"fix"?
>> @@ -221,7 +221,7 @@ static void __init finalize_initrd(void)
>> goto disable;
>> }
>> if (__pa(initrd_end) > PFN_PHYS(max_low_pfn)) {
>> - printk("Initrd extends beyond end of memory");
>> + printk(KERN_ERR "Initrd extends beyond end of memory");
> ^
> There's no newline here, so...
>
>> goto disable;
>> }
>>
>> @@ -232,7 +232,7 @@ static void __init finalize_initrd(void)
>> initrd_start, size);
>> return;
>> disable:
>> - printk(" - disabling initrd\n");
>> + printk(KERN_ERR " - disabling initrd\n");
> ^^^^^^^^
> ... probably this should be KERN_CONT.
> Note that I didn't check the other paths to get here.
Well spotted. I thought I'd checked those but obviously not carefully enough. I shall try again.
Thanks.
Mike.
