Hi Julia, On Tue, Jul 22, 2008 at 06:44:48PM +0200, Julia Lawall wrote: > From: Julia Lawall <julia@xxxxxxx> > > There is a call to local_irq_restore in the normal exit case, so it would > seem that there should be one on an error return as well. > > The semantic patch that makes this change is as follows: > (http://www.emn.fr/x-info/coccinelle/) Correctly spotted - but I decieded to go for below patch instead. Thanks, Ralf From: Ralf Baechle <ralf@xxxxxxxxxxxxxx> [MIPS] tlb-r4k: Nuke broken paranoia error test. Bug originally found and reported by Julia Lawall <julia@xxxxxxx>. I decieded that the whole error check was mostly useless paranoia and should be discarded. It would only ever trigger if r3k_have_wired_reg has a wrong value. Signed-off-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx> diff --git a/arch/mips/mm/tlb-r3k.c b/arch/mips/mm/tlb-r3k.c index a782549..f0cf46a 100644 --- a/arch/mips/mm/tlb-r3k.c +++ b/arch/mips/mm/tlb-r3k.c @@ -246,10 +246,6 @@ void __init add_wired_entry(unsigned long entrylo0, unsigned long entrylo1, old_pagemask = read_c0_pagemask(); w = read_c0_wired(); write_c0_wired(w + 1); - if (read_c0_wired() != w + 1) { - printk("[tlbwired] No WIRED reg?\n"); - return; - } write_c0_index(w << 8); write_c0_pagemask(pagemask); write_c0_entryhi(entryhi);
