On Tue, Jul 15, 2008 at 07:57:31PM +0300, Dmitri Vorobiev wrote: > While building the Malta defconfig, sparse spat the following > warnings: > > >>>>>>>>>>>>>>>>>> > arch/mips/math-emu/kernel_linkage.c:31:6: warning: symbol > 'fpu_emulator_init_fpu' was not declared. Should it be static? > > arch/mips/math-emu/kernel_linkage.c:54:5: warning: symbol > 'fpu_emulator_save_context' was not declared. Should it be > static? > > arch/mips/math-emu/kernel_linkage.c:68:5: warning: symbol > 'fpu_emulator_restore_context' was not declared. Should it be > static? > >>>>>>>>>>>>>>>>>> > > This patch fixes these errors by adding the proper prototypes > to the include/asm-mips/fpu.h header, and actually using this > header in the sparse-spotted source file. I'm not terribly fond of exporting these private prototypes by making their prototypes widely available. I see it's need to make sparse a more productive tool, so I applied the patch though. Thanks, Ralf
