On Fri, 11 Jul 2008, Thomas Bogendoerfer wrote:
> --- a/arch/mips/sgi-ip22/ip22-platform.c
> +++ b/arch/mips/sgi-ip22/ip22-platform.c
> @@ -182,3 +182,14 @@ static int __init sgi_hal2_devinit(void)
> }
>
> device_initcall(sgi_hal2_devinit);
> +
> +static int __init sgi_button_devinit(void)
> +{
> + if (ip22_is_fullhouse())
> + return 0; /* full house has no volume buttons */
> +
> + return IS_ERR(platform_device_register_simple("sgiindybtns",
> + 0, NULL, 0));
^
Shouldn't the instance id be -1, as there can be only one?
(cfr. Documentation/driver-model/platform.txt)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
