Hi all!
While debugging spinlocks I came across a message from the kernel
indicating a problem in the AU1x00 ethernet driver. Seems like the
spinlock for the device is initialised too late, as it is already used
in enable_mac(), which is called via mii_probe() before the init takes
place. The attached patch is working here for a Linux Au1100
2.6.22.6-Rev504 kernel, and as far as I checked should also be
applicable to the current head (line numbers differ).
Comments welcome; I'm quite new to kernel hacking :-)
Martin
Martin Gebert
alpha-bit Gesellschaft für software-engineering mbH
Karl-Zucker-Str. 1a
D-91052 Erlangen
mailto:martin.gebert@xxxxxxxxxxxx
Fon: +49 (9131) 97799-24
Fax: +49 (9131) 97799-28
Handelsregister Fürth HRB 3159
Geschäftsführer Dipl.-Ing. Lothar Müller, Evi Reiß
--- drivers/net/au1000_eth.c.orig 2008-06-26 14:21:53.000000000 +0200
+++ drivers/net/au1000_eth.c 2008-06-26 14:23:00.000000000 +0200
# The following spinlock needs to be initialized earlier, as it is already used
# in enable_mac(), called via mii_probe()
@@ -656,6 +656,7 @@
dev->name, base, irq);
aup = dev->priv;
+ spin_lock_init(&aup->lock);
/* Allocate the data buffers */
/* Snooping works fine with eth on all au1xxx */
@@ -766,7 +767,6 @@
aup->tx_db_inuse[i] = pDB;
}
- spin_lock_init(&aup->lock);
dev->base_addr = base;
dev->irq = irq;
dev->open = au1000_open;
