On Wed, Feb 27, 2008 at 11:16:50AM +0000, Daniel Laird wrote: I was looking through my mail in chronological order so I noticed the older revision of your patch first. So your mail client scambles inline patches: Applying patch patches/0004-01.patch patching file arch/mips/Kconfig Hunk #1 succeeded at 309 (offset -3 lines). patching file arch/mips/kernel/cpu-probe.c Hunk #1 succeeded at 780 (offset 9 lines). Hunk #3 succeeded at 889 (offset 11 lines). patching file arch/mips/Makefile Hunk #1 succeeded at 408 (offset -2 lines). patching file arch/mips/nxp/pnx8550/common/gdb_hook.c patch: **** malformed patch at line 273: IP3106_UART_FIFO_TXFIFO) >> 16) >= 16) Some clients can be convinced to be nice to inline patches. I've collected some advice at http://www.linux-mips.org/wiki/Mailing-patches. If _everything_ else fails, use attachments. > Signed-off-by: daniel.j.laird <daniel.j.laird@xxxxxxx> Yep :-) Ralf
