On Tue, 23 Oct 2007 10:06:45 +0900 (JST) Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote: > On Tue, 23 Oct 2007 09:55:55 +0900, Yoichi Yuasa <yoichi_yuasa@xxxxxxxxxxxxxx> wrote: > > > These clockevent routines are always called with interrupt disabled, > > > so I suppose those spin_lock_irqsave/spin_unlock_irqrestore pairs can > > > be omitted. (or this timer can be used on SMP?) > > > > Yes, it can be used on Malta(SMP). > > Then spin_lock()/spin_unlock() is enough, isn't it? The timer control register(GT_TC_CONTROL_OFS) is shared with 4 timers. The 4 timers are connected with separate IRQ. clockevents_program_event() and clockevents_set_mode() can be called from anywhere(in the kernel). I think that it's necessary for it. Yoichi
