Andrew Sharp wrote: > On Thu, 18 Oct 2007 23:12:32 +0200 Franck Bui-Huu <fbuihuu@xxxxxxxxx> > wrote: > >> Signed-off-by: Franck Bui-Huu <fbuihuu@xxxxxxxxx> >> --- >> arch/mips/kernel/vmlinux.lds.S | 32 >> +++++++++++++++++--------------- 1 files changed, 17 insertions(+), >> 15 deletions(-) >> >> diff --git a/arch/mips/kernel/vmlinux.lds.S >> b/arch/mips/kernel/vmlinux.lds.S index e0a4dc0..2f6c225 100644 >> --- a/arch/mips/kernel/vmlinux.lds.S >> +++ b/arch/mips/kernel/vmlinux.lds.S >> @@ -55,21 +55,23 @@ SECTIONS >> >> /* writeable */ >> .data : { /* Data */ >> - . = . + DATAOFFSET; /* for >> CONFIG_MAPPED_KERNEL */ >> - /* >> - * This ALIGN is needed as a workaround for a bug a gcc >> bug upto 4.1 which >> - * limits the maximum alignment to at most 32kB and >> results in the following >> - * warning: >> - * >> - * CC arch/mips/kernel/init_task.o >> - * arch/mips/kernel/init_task.c:30: warning: alignment of >> â??init_thread_unionâ?? >> - * is greater than maximum object file alignment. Using >> 32768 >> - */ >> - . = ALIGN(_PAGE_SIZE); >> - *(.data.init_task) >> - >> - DATA_DATA >> - CONSTRUCTORS >> + . = . + DATAOFFSET; /* for >> CONFIG_MAPPED_KERNEL */ >> + /* >> + * This ALIGN is needed as a workaround for a bug a >> + * gcc bug upto 4.1 which limits the maximum > > at least fix the text while you're here: 'a bug a gcc bug' > >> + * to at most 32kB and results in the following >> + * warning: >> + * >> + * CC arch/mips/kernel/init_task.o >> + * arch/mips/kernel/init_task.c:30: warning: >> alignment >> + * of â??init_thread_unionâ?? is greater than maximum > > is that utf-8 or something? probably should remove that. > > sorry for the picayunes, but hey as long as you're here changing the > indenting ~:^) > > Okay I'll fix them. Thanks Franck