There is a test in tgafb_mono_imageblit() for a colour image with a
fall-back to cfb_imageblit(). The test is not necessary as the only
caller, which is tgafb_imageblit(), checks it too and only invokes this
function for monochrome images. It looks like a left-over from before
some changes to tgafb_imageblit().
Signed-off-by: Maciej W. Rozycki <macro@xxxxxxxxxxxxxx>
---
Checked with checkpatch.pl and at the run time with an 8-bit TC frame
buffer on a MIPS host.
Please apply.
Maciej
patch-mips-2.6.23-rc5-20070904-tgafb-mono_imageblit-depth-0
diff -up --recursive --new-file linux-mips-2.6.23-rc5-20070904.macro/drivers/video/tgafb.c linux-mips-2.6.23-rc5-20070904/drivers/video/tgafb.c
--- linux-mips-2.6.23-rc5-20070904.macro/drivers/video/tgafb.c 2007-09-04 04:55:46.000000000 +0000
+++ linux-mips-2.6.23-rc5-20070904/drivers/video/tgafb.c 2007-10-14 20:32:13.000000000 +0000
@@ -636,15 +636,6 @@ tgafb_mono_imageblit(struct fb_info *inf
is8bpp = info->var.bits_per_pixel == 8;
- /* For copies that aren't pixel expansion, there's little we
- can do better than the generic code. */
- /* ??? There is a DMA write mode; I wonder if that could be
- made to pull the data from the image buffer... */
- if (image->depth > 1) {
- cfb_imageblit(info, image);
- return;
- }
-
dx = image->dx;
dy = image->dy;
width = image->width;
