On Sat, 6 Oct 2007, Giuseppe Sacco wrote: > @@ -33,7 +33,7 @@ static inline int mkaddr(struct pci_bus *bus, unsigned int devfn, > unsigned int reg) > { > return ((bus->number & 0xff) << 16) | > - (devfn & 0xff) << 8) | > + ((devfn & 0xff) << 8) | > (reg & 0xfc); > } Bad formatting -- using correct one would make the typo more obvious (ditto about the function's header). Maciej