On Thu, Sep 20, 2007 at 11:06:56PM +0900, Yoichi Yuasa wrote: > Update Cobalt Qube series front LED support. > > Signed-off-by: Yoichi Yuasa <yoichi_yuasa@xxxxxxxxxxxxxx> > > diff -pruN -X mips/Documentation/dontdiff mips-orig/drivers/leds/leds-cobalt-qube.c mips/drivers/leds/leds-cobalt-qube.c > --- mips-orig/drivers/leds/leds-cobalt-qube.c 2007-09-14 11:16:22.397075500 +0900 > +++ mips/drivers/leds/leds-cobalt-qube.c 2007-09-14 11:38:52.797470250 +0900 > @@ -3,40 +3,100 @@ > * > * Control the Cobalt Qube series front LED > */ > - > +#include <linux/init.h> > +#include <linux/ioport.h> > +#include <linux/leds.h> > #include <linux/module.h> > +#include <linux/platform_device.h> > #include <linux/types.h> > -#include <linux/kernel.h> > -#include <linux/device.h> > -#include <linux/leds.h> > -#include <asm/mach-cobalt/cobalt.h> > > -static void cobalt_led_set(struct led_classdev *led_cdev, enum led_brightness brightness) > +#include <asm/io.h> <linux/io.h> > + > +#define LED_FRONT_LEFT 0x01 > +#define LED_FRONT_RIGHT 0x02 > + > +static void __iomem *led_port; > +static u8 led_value; > + > +static void qube_front_led_set(struct led_classdev *led_cdev, > + enum led_brightness brightness) > { > if (brightness) > - COBALT_LED_PORT = COBALT_LED_BAR_LEFT | COBALT_LED_BAR_RIGHT; > + led_value = LED_FRONT_LEFT | LED_FRONT_RIGHT; > else > - COBALT_LED_PORT = 0; > + led_value = ~(LED_FRONT_LEFT | LED_FRONT_RIGHT); > + writeb(led_value, led_port); > +} > + > +static struct led_classdev qube_front_led = { > + .name = "qube-front", > + .brightness = LED_FULL, > + .brightness_set = qube_front_led_set, > + .default_trigger = "ide-disk", > +}; > + > +static int __devinit cobalt_qube_led_probe(struct platform_device *pdev) > +{ > + struct resource *res; > + int retval; > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!res) > + return -EBUSY; > + > + led_port = ioremap(res->start, res->end - res->start + 1); > + if (!led_port) > + return -ENOMEM; > + > + led_value = LED_FRONT_LEFT | LED_FRONT_RIGHT; > + writeb(led_value, led_port); > + > + retval = led_classdev_register(&pdev->dev, &qube_front_led); > + if (retval) > + goto err_iounmap; > + > + return 0; > + > +err_iounmap: > + iounmap(led_port); > + led_port = NULL; > + > + return retval; > +} > + > +static int __devexit cobalt_qube_led_remove(struct platform_device *pdev) > +{ > + led_classdev_unregister(&qube_front_led); > + > + if (led_port) { > + iounmap(led_port); > + led_port = NULL; > + } > + > + return 0; > } > > -static struct led_classdev cobalt_led = { > - .name = "cobalt-front-led", > - .brightness_set = cobalt_led_set, > - .default_trigger = "ide-disk", > +static struct platform_driver cobalt_qube_led_driver = { > + .probe = cobalt_qube_led_probe, > + .remove = __devexit_p(cobalt_qube_led_remove), > + .driver = { > + .name = "Cobalt Qube LEDs", Again, please make this something lowercase without spaces. > + .owner = THIS_MODULE, > + }, > }; > > -static int __init cobalt_led_init(void) > +static int __init cobalt_qube_led_init(void) > { > - return led_classdev_register(NULL, &cobalt_led); > + return platform_driver_register(&cobalt_qube_led_driver); > } > > -static void __exit cobalt_led_exit(void) > +static void __exit cobalt_qube_led_exit(void) > { > - led_classdev_unregister(&cobalt_led); > + platform_driver_unregister(&cobalt_qube_led_driver); > } > > -module_init(cobalt_led_init); > -module_exit(cobalt_led_exit); > +module_init(cobalt_qube_led_init); > +module_exit(cobalt_qube_led_exit); > > MODULE_LICENSE("GPL"); > MODULE_DESCRIPTION("Front LED support for Cobalt Qube series"); Ralf