On Wed, Sep 12, 2007 at 11:27:50PM +0900, Yoichi Yuasa wrote: > + .ack = ack_gt641xx_irq, > + .mask = mask_gt641xx_irq, > + .mask_ack = mask_ack_gt641xx_irq, > + .unmask = unmask_gt641xx_irq, You will need a spinlock to guarantee atomicity these irq_chip methods. Otherwise okay I think. Ralf