On Wed, 22 Aug 2007, Yoichi Yuasa wrote:
> On Tue, 21 Aug 2007 22:34:16 +0200
> brm <brm@xxxxxxxxx> wrote:
>
> > Add back support for LASAT platforms.
> >
> > Signed-off-by: Brian Murphy <brian@xxxxxxxxx>
>
> <snip>
>
> > diff --git a/arch/mips/lasat/Kconfig b/arch/mips/lasat/Kconfig
> > new file mode 100644
> > index 0000000..1d2ee8a
> > --- /dev/null
> > +++ b/arch/mips/lasat/Kconfig
> > @@ -0,0 +1,15 @@
> > +config PICVUE
> > + tristate "PICVUE LCD display driver"
> > + depends on LASAT
> > +
> > +config PICVUE_PROC
> > + tristate "PICVUE LCD display driver /proc interface"
> > + depends on PICVUE
> > +
> > +config DS1603
> > + bool "DS1603 RTC driver"
> > + depends on LASAT
>
> If you add new RTC driver, it should go to drivers/rtc.
Nice! So the way to review existing code, is to remove it (accidentally? ;-)
and add it back later? ;-)
> > diff --git a/include/asm-mips/nile4.h b/include/asm-mips/nile4.h
> > new file mode 100644
> > index 0000000..c3ca959
> > --- /dev/null
> > +++ b/include/asm-mips/nile4.h
> > @@ -0,0 +1,310 @@
> > +/*
> > + * asm-mips/nile4.h -- NEC Vrc-5074 Nile 4 definitions
>
> <snip>
>
> > + /*
> > + * Interrupt Programming
> > + */
> > +
> > +#define NUM_I8259_INTERRUPTS 16
> > +#define NUM_NILE4_INTERRUPTS 16
> > +
> > +#define IRQ_I8259_CASCADE NILE4_INT_INTE
> > +#define is_i8259_irq(irq) ((irq) < NUM_I8259_INTERRUPTS)
> > +#define nile4_to_irq(n) ((n)+NUM_I8259_INTERRUPTS)
> > +#define irq_to_nile4(n) ((n)-NUM_I8259_INTERRUPTS)
> > +
> > +extern void nile4_map_irq(int nile4_irq, int cpu_irq);
> > +extern void nile4_map_irq_all(int cpu_irq);
> > +extern void nile4_enable_irq(unsigned int nile4_irq);
> > +extern void nile4_disable_irq(unsigned int nile4_irq);
> > +extern void nile4_disable_irq_all(void);
> > +extern u16 nile4_get_irq_stat(int cpu_irq);
> > +extern void nile4_enable_irq_output(int cpu_irq);
> > +extern void nile4_disable_irq_output(int cpu_irq);
> > +extern void nile4_set_pci_irq_polarity(int pci_irq, int high);
> > +extern void nile4_set_pci_irq_level_or_edge(int pci_irq, int level);
> > +extern void nile4_clear_irq(int nile4_irq);
> > +extern void nile4_clear_irq_mask(u32 mask);
> > +extern u8 nile4_i8259_iack(void);
> > +extern void nile4_dump_irq_status(void); /* Debug */
>
> nile4 IRQ functions don't exist.
Yep, those are for the NEC DDB Vrc-5074 (still to be resurrected, one day ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
