Re: [MIPS] Use generic NTP code for all MIPS platforms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 13 Aug 2007 15:26:17 +0100, linux-mips@xxxxxxxxxxxxxx wrote:
> Author: Ralf Baechle <ralf@xxxxxxxxxxxxxx> Mon Aug 13 15:26:12 2007 +0100
> Commit: 4c1ebc8bc02fa6f30ccddacca7552dc2c8686792
> Gitweb: http://www.linux-mips.org/g/linux/4c1ebc8b
> Branch: master
> 
> Signed-off-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx>

With this, we now have this in Kconfig:

config GENERIC_CMOS_UPDATE
	bool
	default y

I think there are no point using GENERIC_CMOS_UPDATE for users of the
new-style RTC_CLASS drivers or platforms with no RTC.

There are some possible ways:

A) Make default of GENERIC_CMOS_UPDATE to "n" and select it explicitly
   on platforms which need it.

B) Make default of GENERIC_CMOS_UPDATE depends on CONFIG_RTC_CLASS.

C) set no_sync_cmos_clock to 0 on time_init() if rtc_mips_set_mmss was
   NULL and rtc_mips_set_time and was null_rtc_set_time.

And combinations ot variations of those...

Which are preferred?  Any comments?

---
Atsushi Nemoto


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux