On Wednesday 01 August 2007, Christoph Hellwig wrote: > On Wed, Aug 01, 2007 at 09:28:07AM +0200, Domen Puncer wrote: > > > It doesn't make any assumption on struct clk, it's just a > > > wrapper around functions from clk.h. > > > Point of this patch was to abstract exported functions, since > > > arch/powerpc/ can support multiple platfroms in one binary. > > > > So... the thread just ended without any consensus, ACK or whatever. > > > > Choices I see: > > - have EXPORT_SYMBOL for clk.h functions in ie. lib/clock.c and have > > every implemenation fill some global struct. > > - leave this patch as it is, abstraction only for arch/powerpc/. That seems the best solution for now, I agree. > > - or I can just forget about this, and leave it for the next sucker > > who will want nicer clock handling in some driver > > It seems like arm really wants this optimized to the last cycle > and no abstraction inbetween so we're probably stuck with the status > quo. I'm pretty sure this will get too messy sooner and later and > people will clean the mess up, but due to the political issues I > don't think it's fair to put that burden on you just for submitting > the powerpc implementation. > > So, please leave the patch as-is. >
