Re: Sync SiByte system code to the new DUART driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2 Aug 2007, Ralf Baechle wrote:

> Hmm...  You just found the tip of the iceberg ...
> 
> $ git grep -w CONFIG_SIBYTE_SB1250_DUART | cat -
> arch/mips/configs/bigsur_defconfig:CONFIG_SIBYTE_SB1250_DUART=y
> arch/mips/configs/sb1250-swarm_defconfig:CONFIG_SIBYTE_SB1250_DUART=y
> arch/mips/sibyte/bcm1480/irq.c:#ifdef CONFIG_SIBYTE_SB1250_DUART
> arch/mips/sibyte/bcm1480/irq.c:#ifdef CONFIG_SIBYTE_SB1250_DUART
> arch/mips/sibyte/cfe/console.c:#ifdef CONFIG_SIBYTE_SB1250_DUART
> arch/mips/sibyte/sb1250/irq.c:#ifdef CONFIG_SIBYTE_SB1250_DUART
> arch/mips/sibyte/sb1250/irq.c:#ifdef CONFIG_SIBYTE_SB1250_DUART

 Most of that stuff does not work anymore anyway and now you risk link 
errors. ;-)  I do not think there is place for driver-related #ifdefs 
under arch/ anyway, the answer being platform devices.  Though chances are 
nobody might be bothered to ever implement them here.

 Also the #ifdefs in arch/mips/sibyte/cfe/console.c do not make sense to 
me.

  Maciej


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux