On Wed, 11 Jul 2007, Shane McDonald wrote: > Hi Robert: > > Maybe I should have gone into more detail in my initial response. > > There's a patch posted to the i2c mailing list that adds > CONFIG_PMCTWILED into drivers/i2c/chips/Kconfig. It probably hasn't > been accepted yet, so that's why it's not showing up in any Kconfig > on l-m.o. The patch shows up here: > http://lists.lm-sensors.org/pipermail/i2c/2007-March/001003.html. yes, i've seen that before -- the code to check a CONFIG option shows up before the actual Kconfig entry for it. it would, of course, be nice if those two things arrived simultaneously. oh, well. > I don't know why they have defined CONFIG_SQUASHFS in their > defconfig, although I believe their distribution includes squashfs > patches. Their patch to define the defconfig seems to include > it--the reason why is probably a question for the original patch: > http://www.linux-mips.org/archives/linux-mips/2007-06/msg00197.html. i'm singularly unenthusiastic about the idea of hardcoding CONFIG_ variables into defconfig files if they're not defined in Kconfig files in the main kernel tree itself. that way lies bad design and confusion. if their distro is going to add squashfs patches, then it should also add the CONFIG-related code for it as well, and not dump that stuff into the main tree where it makes no sense. rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?title=Main_Page ========================================================================
