On Mon, 25 Jun 2007 02:28:22 +0200, Ralf Baechle <ralf@xxxxxxxxxxxxxx> wrote: > <jgarzik> Ralf: probably not... :) > <jgarzik> Ralf: dev->open() assumes dev->dev_addr[] is filled in, when interface goes up, and each NIC driver should use that and write the MAC address in dev->dev_addr[] to its RX filter / MAC address registers > <jgarzik> Ralf: the default value should be filled in before netdev is registers > <jgarzik> registered > <jgarzik> Ralf: well, ->open() is just the manifestation of interface-up operation, with all the notifications that that entails. At that point, NIC driver should not be touching dev->dev_addr[], because it may have already been supplied by the user via ifconfig, when the interface was down. > <jgarzik> Ralf: dev->dev_addr[] should definitely be filled in before the call to register_netdev() OK, I'll go another approach. For now candidate is passing the dev_addr via special platform_device. Hopefully it would be acceptable ... --- Atsushi Nemoto
