On Thu, Jun 21, 2007 at 05:37:25AM -0700, Daniel Laird wrote: > Please find the new patch below - I hope it is following the correct rules > now. This is a good opportunity to advertise the checkpatch.pl script which is part of the latest kernel once more. For example running it against your patch results gives: [ralf@denk linux-queue]$ scripts/checkpatch.pl /tmp/xxx line over 80 characters #107: FILE: arch/mips/philips/pnx8550/common/setup.c:117: + (PR4450_CMEM_SIZE_128MB << PR4450_CMEMB_SIZE) | line over 80 characters #112: FILE: arch/mips/philips/pnx8550/common/setup.c:122: + (PR4450_CMEM_SIZE_128MB << PR4450_CMEMB_SIZE) | trailing whitespace #141: >> +++ kernel-new/arch/mips/philips/pnx8550/common/setup.c $ Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. [ralf@denk linux-queue]$
