Re: [linux-usb-devel] [PATCH 11/12] drivers: PMC MSP71xx USB driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> This does far too much to be a single patch.  It needs to be broken up.

Agreed.  300+ KB is not digestible at all.

Most maintainers like to see patches on the order of 10 KB; that much
is easy to review.  New drivers are rarely that small of course, but
that should give you some understanding of just how excessive this is...

But the fact that this one "driver" patch touched so many other files
outside its own directory is a dead giveaway that it's got something
pretty wrong...

- Dave



[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux