Hello. Ralf Baechle wrote:
Unify lib-{32,64}/watch.S into lib/watch.S and remove lib-{32,64} completely.
The old 64-bit __watch_set() expected an physical address and the old 32-bit __watch_set() expected a KSEG0 virtual address. The new unified __watch_set() is based on the 64-bit one. Since there is no real user of the __watch_set(), this incompatibility would not cause any problem.
I think we can simply drop the entire watchpoint support. This was only ever working on R4000/R4400 and even there only somewhat useful for kernel debugging. So if we ever use watchpoint support I think something needs to be developed from scratch.
Watchpoints *could* be supported as part of KGDB, BTW.
Ralf
WBR, Sergei
